vlsi commented on code in PR #6291:
URL: https://github.com/apache/jmeter/pull/6291#discussion_r1915090765


##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/PostWriter.java:
##########
@@ -299,7 +296,7 @@ public void setHeaders(URLConnection connection, 
HTTPSamplerBase sampler) throws
 
                     // Just append all the parameter values, and use that as 
the post body
                     StringBuilder postBodyBuffer = new StringBuilder();
-                    for (JMeterProperty jMeterProperty : 
sampler.getArguments()) {
+                    for (JMeterProperty jMeterProperty : 
sampler.getArguments().getEnabledArguments()) {

Review Comment:
   It looks like we should not filter "empty" arguments from here.
   
   Frankly, I do not understand the reason why "empty named" 
(`.isSkippable(...)`) arguments are included only in certain cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to