vlsi commented on code in PR #6406:
URL: https://github.com/apache/jmeter/pull/6406#discussion_r1948446591
##########
src/core/src/main/java/org/apache/jmeter/report/processor/SumAggregator.java:
##########
@@ -25,7 +27,7 @@
public class SumAggregator implements Aggregator {
private long count = 0;
- private double sum = 0;
+ private BigDecimal sum = BigDecimal.ZERO;
Review Comment:
What is the point of using `BigDecimal` here?
##########
bin/reportgenerator.properties:
##########
@@ -34,6 +34,8 @@
# Reporting configuration
#---------------------------------------------------------------------------
+jmeter.reportgenerator.msns=ms
Review Comment:
`jmeter.reportgenerator.msns` is a strange property name. Consider someone
would need `minutes` later. I would suggest something like
`jmeter.reportgenerator.time.unit=ns|ms|minutes|...`.
However,
##########
src/jorphan/src/main/java/org/apache/jorphan/math/StatCalculator.java:
##########
@@ -38,9 +40,9 @@ public abstract class StatCalculator<T extends Number &
Comparable<? super T>> {
// We use a TreeMap because we need the entries to be sorted
// Running values, updated for each sample
- private double sum = 0;
+ private BigDecimal sum = BigDecimal.ZERO;
- private double sumOfSquares = 0;
+ private BigDecimal sumOfSquares = BigDecimal.ZERO;
Review Comment:
Does this change belong to "support nanoseconds" PR?
If you want to improve precision of `StatCalculator`, I would suggest
creating a separate PR and discuss it there.
Have you checked if the change from `double` to `BigDecimal` produces no
significant performance regressions?
##########
src/jorphan/src/main/java/org/apache/jorphan/math/StatCalculatorLong.java:
##########
@@ -17,13 +17,15 @@
package org.apache.jorphan.math;
+import java.math.BigInteger;
+
/**
* StatCalculator for Long values
*/
-public class StatCalculatorLong extends StatCalculator<Long> {
+public class StatCalculatorLong extends StatCalculator<BigInteger> {
Review Comment:
The signature change would break backward compatibility, so previous usages
would become invalid. I'm not sure breaking JMeter clients is the right thing
to do.
##########
src/core/src/test/kotlin/org/apache/jmeter/util/CalculatorTest.kt:
##########
@@ -66,11 +66,11 @@ class CalculatorTest {
@Test
fun mean() {
assertEquals(0.0, calculator.mean, "mean()")
- calculator.addSample(SampleResult(10, 40))
+ calculator.addSample(SampleResult(10 * 1000000L, 40 * 1000000L))
assertEquals(40.0, calculator.mean, 0.001, "mean(40)")
- calculator.addSample(SampleResult(10, 42))
+ calculator.addSample(SampleResult(10 * 1000000L, 42 * 1000000L))
assertEquals((40.0 + 42.0) / 2, calculator.mean, 0.001, "mean(40, 42)")
- calculator.addSample(SampleResult(10, 48).apply { sampleCount = 2 })
+ calculator.addSample(SampleResult(10 * 1000000L, 48 * 1000000L).apply
{ sampleCount = 2 })
Review Comment:
It does not sound right to modify the existing tests. Please refrain from
modifying the existing tests unless it is absolutely necessary.
Otherwise it looks like you break backward compatibilty as we can't require
all the plugins to rewrite and recompile their code to add `* 1000000L` all
over the place.
##########
bin/testfiles/HTMLReportTestFile.csv:
##########
@@ -1,256 +1,256 @@
timeStamp,elapsed,label,responseCode,responseMessage,threadName,dataType,success,failureMessage,bytes,sentBytes,grpThreads,allThreads,URL,Latency,IdleTime,Connect
-1551783627191,351,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783627543,192,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783627735,131,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783627866,261,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783628128,266,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783628395,279,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783628674,304,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783628979,353,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783629333,196,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783629530,139,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783629670,278,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783629949,303,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783630253,351,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783630605,194,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783630799,134,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783630934,268,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783631202,282,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783631485,308,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783631794,108,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783631903,217,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783632120,180,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783632301,107,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783632408,213,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783632622,171,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783632794,342,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783633137,176,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783633313,353,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783633666,196,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783633863,137,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783634001,275,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783634276,296,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783634573,336,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783634910,164,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783635075,328,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783635404,148,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783635552,297,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783635850,338,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783636189,168,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783636357,337,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783636695,164,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783636859,329,JR-KO,400,Bad request,Thread Group
1-1,text,false,,20,8,1,1,null,0,0,0
-1551783637189,147,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783637337,296,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783637634,339,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783637974,168,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783638142,337,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783638480,164,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783638644,329,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783638974,148,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783639122,297,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783639420,338,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783639759,168,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783639927,337,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783640264,164,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783640429,329,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783640758,148,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783640907,295,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783641203,336,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783641540,164,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783641705,328,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783642034,148,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783642182,297,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783642480,339,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783642819,169,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783642989,338,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783643327,166,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783643493,333,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783643827,156,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783643983,313,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783644297,116,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783644413,233,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783644647,211,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783644858,168,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783645027,336,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783645363,163,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783645527,325,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783645853,142,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783645995,285,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783646280,315,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783646596,120,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783646717,241,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783646958,227,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783647186,200,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783647386,146,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783647533,292,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783647826,331,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783648157,152,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783648310,304,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783648615,353,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783648968,199,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783649167,142,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783649310,284,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783649594,314,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783649909,118,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783650027,238,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783650265,220,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783650486,185,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783650671,116,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783650788,232,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783651021,210,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783651231,166,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783651398,332,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783651730,155,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783651886,309,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783652196,110,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783652307,221,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783652528,187,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783652715,121,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783652836,241,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783653078,227,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783653306,200,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783653506,146,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783653653,292,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783653945,330,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783654275,150,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783654425,300,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783654726,344,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783655071,180,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783655251,106,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783655358,212,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783655571,170,JR-KO,400,Bad request,Thread Group
1-1,text,false,,20,8,1,1,null,0,0,0
-1551783655741,340,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783656081,171,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783656253,342,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783656595,174,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783656770,348,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783657118,189,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783657307,123,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783657430,245,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783657675,235,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783657911,215,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783658126,176,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783658303,352,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783658656,195,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783658852,136,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783658989,272,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783659262,291,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783659553,327,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783659880,145,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783660025,290,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783660316,324,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783660641,140,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783660782,281,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783661063,307,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783661370,105,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783661476,210,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783661687,166,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783661853,333,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783662186,157,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783662343,313,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783662657,116,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783662774,232,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783663007,211,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783663219,168,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783663387,337,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783663725,164,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783663889,329,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783664218,149,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783664367,297,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783664664,339,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783665004,168,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783665172,337,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783665510,164,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783665675,328,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783666004,148,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783666152,297,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783666450,339,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783666789,168,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783666958,336,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783667295,164,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783667460,328,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783667789,148,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783667937,297,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783668234,339,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783668574,168,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783668742,337,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783669079,164,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783669244,328,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783669573,147,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783669720,295,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783670015,335,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783670351,162,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783670513,324,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783670837,137,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783670975,274,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783671249,294,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783671544,333,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783671877,157,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783672035,314,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783672349,118,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783672468,237,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783672705,220,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783672926,185,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783673111,116,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783673228,232,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783673460,210,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783673671,165,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783673836,331,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783674167,153,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783674320,305,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783674626,100,JR-KO,400,Bad request,Thread Group
1-1,text,false,,20,8,1,1,null,0,0,0
-1551783674727,201,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783674928,149,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783675077,297,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783675374,339,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783675714,168,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783675882,337,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783676219,164,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783676384,327,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783676712,146,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783676859,292,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783677152,331,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783677484,153,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783677638,306,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783677945,104,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783678050,208,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783678259,163,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783678422,327,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783678750,144,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783678894,289,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783679183,323,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783679507,135,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783679643,272,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783679915,290,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783680205,325,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783680530,141,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783680671,281,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783680952,307,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783681260,104,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783681365,208,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783681574,163,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783681738,326,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783682065,144,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783682209,289,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783682499,323,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783682822,137,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783682960,274,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783683234,293,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783683527,332,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783683859,155,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783684014,309,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783684323,108,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783684432,216,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783684648,178,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783684827,101,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783684928,203,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783685132,151,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783685283,303,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783685587,350,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783685938,192,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783686130,131,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783686261,261,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783686523,267,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783686790,280,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
-1551783687071,305,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
+1551783627191000000,351000000,JR-OK,200,Good request,Thread Group
1-1,text,true,,18,8,1,1,null,0,0,0
Review Comment:
Please refrain from modifying the existing tests. Please create a new test
for the feature you add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
