vlsi commented on PR #6389: URL: https://github.com/apache/jmeter/pull/6389#issuecomment-3584510147
There's an edge case: `Save response as MD5` + `compressed response` + `SampleResult#getBodySizeAsLong`. It is not clear what would be the way to make it working with "delayed decompression". When it comes to `getBodySizeAsLong`, I think it would be fine if we track the number of uncompressed bytes. However, `md5(compressed)` and `md5(uncompressed)` are different, so it is a breaking change. Currently, JMeter computes MD5 over decompressed result, and if we compute MD5 over the compressed data, then the result will change. I'm not sure how "save as md5" is typically used, however, if users have assertions for MD5 values, then the assertions would start failing if we checksum uncompressed stream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
