potiuk commented on PR #6709: URL: https://github.com/apache/jmeter/pull/6709#issuecomment-4607395184
Pushed a v1 folding in your review — thanks @vlsi @milamberspace. What changed: - **RMI SSL defaults** (your source review): adopted in full — §4/§5a/§8 now state `server.rmi.ssl.disable=false`, mutual client-auth, keystore-not-shipped (engine won't start unprotected), resolved-address bind. "Unauthenticated/RCE-by-default" is now explicitly **not** valid; an exposed engine needs `server.rmi.ssl.disable=true`, classified `OUT-OF-MODEL: non-default-config` (@vlsi's point — runtime opt-out, no rebuild), added as a distinct §13 disposition. CVE-2019-0187 noted as the class these defaults close. - **Security Manager**: dropped as a recommended defense (§5/§9/§10) — flagged deprecated for removal (JEP 411); the real distributed defense is RMI-over-SSL. Noted `security.html`'s recommendation should be updated. - **Opening vs running** (@vlsi): adopted your line — opening a `.jmx` is safe given trust in the distribution's *existing* classes; in-model only if opening generates and executes a *new* class. - **Hostile SUT** (@vlsi → @milamberspace): moved out of model — the tester targets only systems they own/are authorised to test, so parser robustness vs a hostile SUT is hardening, not a claimed property. Marked "pending @milamberspace" in the doc; happy to add a narrow in-model carve-out if you'd both prefer. - Added @milamberspace's "disable RMI SSL then expose jmeter-server" misuse (§11). §14 waves 1–2 marked answered. On the broader "AI-facing files" point (@milamberspace): strongly agree it's worth an ASF-level convention. Happy to help take it to the relevant list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
