milamberspace commented on PR #6742: URL: https://github.com/apache/jmeter/pull/6742#issuecomment-5256955300
A few notes on `xdocs/changes.xml`: ### Missing `<pr>6742</pr>` reference None of the entries this PR adds carry a `<pr>` tag, unlike their neighbors in the same lists (e.g. `<pr>6268</pr>`, `<pr>6620</pr>`). Worth adding `<pr>6742</pr>` to: - the four new bullets under *Changes → HTTP Samplers and Test Script Recorder* (HTTP/2 multiplexing for HttpClient5 and Java, default `User-Agent` for both), - the HttpClient5/HttpCore5 version-bump bullet under *Changes → Non-functional changes*. ### Maybe group the HttpClient5/HTTP2 entries under one heading The four new *HTTP Samplers* bullets (HTTP/2 multiplexing ×2, default `User-Agent` ×2) currently sit flat in the same list as older, unrelated entries (IE conditional comments, argument enable/disable, multipart charset, redirect method preservation…). They're really one coherent piece of work — might read better with a short lead-in grouping them, e.g. a one-line "HTTP/2 support for the HttpClient5 and Java sampler implementations:" before the four bullets, so a reader scanning the changelog sees it as one feature rather than four scattered items. No strong opinion on the exact markup — this file doesn't have a `<h4>` sub-heading precedent elsewhere, so whatever's lightest. ### The pooled-connection re-validation entry shouldn't be in *Bug fixes* > *Re-validate pooled connections of the HttpClient5 sampler implementation after they have been idle...* This fixes a bug introduced and fixed entirely within this same unreleased PR — it never shipped in any JMeter release, so it isn't a "bug fix" from the changelog reader's perspective (there's nothing between two releases for them to have hit). Suggest dropping this bullet from *Bug fixes → HTTP Samplers and Test Script Recorder* entirely, since the fixed behavior is just folded into the feature as it ships. If it's worth keeping any trace of it at all, `httpclient5.validate_after_inactivity` could just be mentioned in passing in one of the *Changes* bullets above instead — but a dedicated "bug fix" entry for a bug the released code never had reads as noise. ### Thanks section Missing `Andreas Lind (github.com/andreaslind01)` in the *Thanks* list at the bottom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
