milamberspace commented on PR #6736: URL: https://github.com/apache/jmeter/pull/6736#issuecomment-5306597157
While testing, I noticed that this PR (#6736 , cURL request view) and #6742 (HttpClient5 sampler with HTTP/2 support) are somewhat related. I checked out both PRs together on a temporary branch and ran an HTTP/2 request. As expected, the generated cURL command does not include --http2 (nor --http2-prior-knowledge). Likewise, forcing an HTTP/1.1 request does not emit --http1.1. This is normal: #6736 currently has no knowledge of #6742. @vlsi + @poliakov-alex : would you be OK with linking these two PRs? If so, my suggestion would be: 1. Merge #6742 first, after a positive review (@vlsi). 2. Then update #6736 to emit the proper --http2 / --http2-prior-knowledge / --http1.1 flags based on the sampler's protocol setting (@poliakov-alex ) 3. Merge #6736 after review (@vlsi + me). These 2 PRs would bring some very nice new capabilities to JMeter 6. (cc @andreaslind01 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
