milamberspace commented on PR #6756: URL: https://github.com/apache/jmeter/pull/6756#issuecomment-5469306750
@ashrafiucse Thanks for the fix (or new behavior?). The code change looks correct. But before merge: this changes affect a long-standing runtime behavior: JMeter has been sending expired cookies for years. Some test plans may rely on that, even without knowing it. This is especially true for long-running endurance tests that outlive a cookie's expiry. With this PR, when the cookie expires, the auth is finish... This PR will be release with the next major release of JMeter (i.e. 6.0.0), so please improve the PR with: * Move or reword the changes.xml entry so it reads as a behaviour change, not just a bug fix, add some word in "Incompatible changes" in changes.xml * Add a note in the HTTP Cookie Manager manual i.e. component_reference.xml. About that expired cookies are no longer sent, and warn about the impact on long-running tests. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
