kalayciburak opened a new pull request, #6767: URL: https://github.com/apache/jmeter/pull/6767
## Description Configure the Woodstox `XMLOutputFactory` used by `JMeterStaxDriver` to replace characters that are illegal in XML 1.0 (NUL and other C0 controls) instead of aborting the write. After the xmlpull to Woodstox migration, saving a JTL sample or a JMX test plan that contains those characters throws `WstxIOException` (`Invalid null character` / `Invalid white space character`). Binary request bodies recorded from browsers (for example Mozilla telemetry) hit this path. ## Motivation and Context Fixes #6761 Woodstox's default `InvalidCharHandler.FailingHandler` rejects those characters. Replacing them with a space keeps the XML well-formed so recording and test-plan save succeed, matching the previous xmlpull behaviour of not failing the save. ## How Has This Been Tested? - RED then GREEN: `./gradlew :src:core:test --tests org.apache.jmeter.save.SaveServiceInvalidXmlCharTest` — 2/0 - Nearby: `./gradlew :src:core:test --tests org.apache.jmeter.save.SaveServiceInvalidXmlCharTest --tests org.apache.jmeter.save.TestCSVSaveService` — 13/0 - `./gradlew :src:core:style` — BUILD SUCCESSFUL ## Types of changes - Bug fix (non-breaking change which fixes an issue) ## Checklist: - [x] My code follows the [code style][style-guide] of this project. - [x] I have updated the documentation accordingly. [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
