sharanggupta opened a new pull request, #6847:
URL: https://github.com/apache/jmeter/pull/6847

   ## Description
   `MapPropertyTest.testGetPropertyTypeOfStringElements` was added without 
`@Test` in d3a0d32 (2018), so it never ran. Its name says string elements but 
it used `Integer` values, so it now uses `String` values, which a `MapProperty` 
stores as `StringProperty`. `MapProperty.getPropertyType()` also gets the null 
check `CollectionProperty.getPropertyType()` already has, so the constructor no 
longer relies on `getBlankProperty()` catching a `NullPointerException`.
   
   ## How Has This Been Tested?
   `./gradlew :src:core:test` and `./gradlew classes style`; the enabled test 
fails if `getPropertyType()` ignores the map's values.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to