[
https://issues.apache.org/jira/browse/JOHNZON-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640604#comment-16640604
]
Romain Manni-Bucau commented on JOHNZON-192:
--------------------------------------------
Hi Simone
I have a mixed feeling about it since some parts are still not typed and we
loose the full codestyle handling.
Also adding dependencies for such trivial code is maybe not worth it from my
perspective.
Romain
> Switch johnzon-maven-plugin class generation from manual source writer to a
> more robust solution
> ------------------------------------------------------------------------------------------------
>
> Key: JOHNZON-192
> URL: https://issues.apache.org/jira/browse/JOHNZON-192
> Project: Johnzon
> Issue Type: Improvement
> Affects Versions: 1.1.10
> Reporter: Simone Tripodi
> Priority: Major
> Fix For: 1.1.11
>
>
> Currently, generated sources are obtained by writing strings to a writer; it
> works for current needs but is not really comfort to maintain.
> I am going to submit a PullRequest to improve that current situation by
> delegating the Java source code generation to
> https://github.com/square/javapoet, a more robust and strongly-typed solution
> provided by Square.
> Testing is also something that can be improved, in the Pull request I am
> proposing a (simple) syntax-tree comparison, rather than mere string
> comparison.
> Generated source code is still the same, even if with a slightly different
> format, but Mojo source is easier to maintain.
> I hope you'll like the PR :)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
