[
https://issues.apache.org/jira/browse/JOHNZON-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764130#comment-16764130
]
Alexander Falb edited comment on JOHNZON-199 at 2/9/19 12:37 PM:
-----------------------------------------------------------------
Sure. Just sent the PR :) - https://github.com/apache/johnzon/pull/37
First commit is a rework of the unit test. The old test stopped at the first
violated assert.
The second commit is the actual change.
was (Author: elexx):
Sure. Just sent the PR :)
First commit is a rework of the unit test. The old test stopped at the first
violated assert.
The second commit is the actual change.
> JohnzonIgnore#minVersion logic is negated?
> ------------------------------------------
>
> Key: JOHNZON-199
> URL: https://issues.apache.org/jira/browse/JOHNZON-199
> Project: Johnzon
> Issue Type: Bug
> Affects Versions: 1.1.10
> Reporter: Alexander Falb
> Priority: Major
>
> When a field is annotated with {{@JohnzonIgnore(minVersion = X)}} and a
> json-string is written via {{Mapper}}, the field is only included when the
> mapper is configured with {{.setVersion(Y)}}, where Y < X}.
> According to the documentation of {{JonzonIgnore#minVersion}} and
> [https://johnzon.apache.org/#aJohnzonIgnore] it should be included for Y >= X.
> Is the documentation wrong or the implementation?
> Example: [https://gist.github.com/elexx/ab5dc1f3611913a0d9f409234fbecc84]
> outputs
> {code:java}
> {}{code}
> I expected it to be
> {code:java}
> { value="valuevalue" }{code}
> To sumarize: with {{@JohnzonIgnore(minVersion = 2)}} the outputs are the
> following:
> {code:java}
> .setVersion(1) ... {"value":"valuevalue"}
> .setVersion(2) ... {}
> .setVersion(3) ... {}
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
