leadpony commented on issue #40: JOHNZON-209 Fix JsonObject#toString() to 
escape key names.
URL: https://github.com/apache/johnzon/pull/40#issuecomment-487255025
 
 
   Hello @rmannibucau, 
   I tried moving String + charAt() to toCharArray() + [].
   The result are:
   ```
   Benchmark                                (name)   Mode  Cnt       Score      
Error  Units
   JsonpBenchmark.jsonValueToString  glossary.json  thrpt   25  380042.206 ± 
5879.107  ops/s
   ```
   It is slower than the previous measurement. This is because `toCharArray()` 
allocates additional memory for array and the memory allocation makes the code 
slower.
   The modified code is available at branch 
[fix-tostring-using-chararray](https://github.com/leadpony/johnzon/tree/fix-tostring-using-chararray)
 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to