leadpony edited a comment on issue #40: JOHNZON-209 Fix JsonObject#toString() to escape key names. URL: https://github.com/apache/johnzon/pull/40#issuecomment-487269528 Hi @rmannibucau, Optimizing code WITHOUT measurement is almost always bad. I do not feel like optimizing the current code further because `JsonObject.toString()` in the Reference Implementation is twice faster than that of Johnzon 1.1.11 (current release) as shown below. ``` Benchmark (name) Mode Cnt Score Error Units JsonpBenchmark.jsonValueToString glossary.json thrpt 25 940578.189 ± 18156.788 ops/s ``` RI is not highly optimized but fast and correct. We need to rework completely the algorithm, if you would like to make it twice faster. Right now, correctness is of first priority for me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services