[ https://issues.apache.org/jira/browse/JOHNZON-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932149#comment-16932149 ]
Markus Karg commented on JOHNZON-276: ------------------------------------- Please review PR 44 on Github: [https://github.com/apache/johnzon/pull/44.|https://github.com/apache/johnzon/pull/44] > StackOverflowError in DefaultPropertyVisibilityStrategy > ------------------------------------------------------- > > Key: JOHNZON-276 > URL: https://issues.apache.org/jira/browse/JOHNZON-276 > Project: Johnzon > Issue Type: Bug > Components: JSON-B > Affects Versions: 1.2.1 > Reporter: Markus Karg > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The following code produces a StackOverflowError: > @JsonVisibility(DefaultPropertyVisibilityStrategy.class) > public final class C { > @JsonProperty private boolean foo; > } > The problem is caused by the fact that this strategy tries to compare "this" > by "==" with a _new instance_ of itself, which certainly fails, because the > new copy is definitively a different reference than the one currently > executed and instantiated due to the class annotation. > The fix is simple: Adding an equals method just comparing the class type (as > the strategy has no members other than a cache), and calling that instead of > "==". -- This message was sent by Atlassian Jira (v8.3.4#803005)