rmannibucau commented on issue #44: Fix for [JOHNZON-276]: StackOverflowError URL: https://github.com/apache/johnzon/pull/44#issuecomment-532618792 @mkarg == enable to subclass the method and keep it working/handlable (I agree it requires a threadlocal which is ugly but once again this class must never be used in user code), instanceof breaks that directly bypassing subclass logic all the time. Also note I don't reject the change but want to highlight it would require some change and is not needed since your use case works on master (1.2.0 I guess) without any visibility hack.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services