mkarg commented on issue #44: Fix for [JOHNZON-276]: StackOverflowError URL: https://github.com/apache/johnzon/pull/44#issuecomment-532657947 @rmannibucau Actually the use case FAILS on master (1.2.0-SNAPSHOT) and NEEDS the visibility hack! Regarding subclasses, we could replace `instanceof` by `Class.isAssignableFrom`. Still no need to use `==` or a threadlocal hack. BTW, AFAIK `o instanceof X` will be true even if o is an instance of a *subclass of X*, so it *will* work with subclasses even with `instanceof`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
