rmannibucau commented on issue #49: JOHNZON-279 Fails to build on Travis CI (Xenial) URL: https://github.com/apache/johnzon/pull/49#issuecomment-534430188 Just for the record: > Actually the PR was there before https://api.github.com/repos/apache/johnzon/pulls/49 -> your PR was done at 2019-09-23T17:33:12Z https://api.github.com/repos/apache/johnzon/commits/d99eb3f41276644d7f178ffb76f22eacf99fe93a -> my commit was done at 2019-09-23T17:28:15Z So strictly speaking your last comment is a bit unfair since I pushed before you PR-ed so the PR link in the jira was updated after the fix was pushed so at the end credits are clear (to be very explicit, current travis.yml credit are more about https://github.com/Talend/component-runtime/blob/master/.travis.yml than your PR). Now, I personally don't care much about public credit (I only care about projects) so I am happy to drop my last commit if you integrate the changes in travis.yml (https://github.com/apache/johnzon/pull/49#issuecomment-534287843: cache, drop after_install, and probably openjdk11 support to not loose it). Side note question which was probably not clear in the mentionned commit: do you use travis for your personal dev? If not we can also just drop the file since nobody uses it (you hit that issue quite late regarding your previous contributions so not sure you use it or just spotted the issue during another hack).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
