mkarg commented on issue #49: JOHNZON-279 Fails to build on Travis CI (Xenial) URL: https://github.com/apache/johnzon/pull/49#issuecomment-534452097 @rmannibucau I am sorry for accusing you, it just looked different from my side. I checked the logs again, and you are right, apparently we worked roughtly in parallel on that issue and pushed just minutes in sequence. It seems we both were too eagerly hacking code; we should more clearly put markers in the JIRA when we start on an issue. (Unfortunately we cannot use the JIRA assignee feature as only committers can be set there). Regarding the outcome of our dispute: As not being paid for this actually I do care **a lot** about credits on all the open source work I did in the past 20+ years. As we both worked on the same issue actually, my proposal would be to drop your commit, and accept my PR, and put your commit ontop of it. So both solutions are mentioned correctly. I think this would be most fair to both of us. Again, sorry for the confusion. Regarding Travis itself, I just fixed it in the first place solely because it kept sending me error messages. I do not _rely_ on the outcome. On the other hand, as it is fixed now, why should we drop it? It comes in really handy actually (I'm used to it from other open source projects, like JAX-RS, where we actually rely on it by blocking Github Merge button). As the nightly builds of Johnzon are apparently broken anyways, we could instead add the nightly builds to Travis CI instead of dropping it? Anyways, I am not the project lead. This is not my decision.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
