rmannibucau commented on a change in pull request #53: JOHNZON-282: add support
for @JsonbTypeAdapter at class level
URL: https://github.com/apache/johnzon/pull/53#discussion_r328826339
##########
File path:
johnzon-jsonb/src/main/java/org/apache/johnzon/jsonb/JsonbAccessMode.java
##########
@@ -868,8 +868,10 @@ public void close() throws IOException {
ReaderConverters(final DecoratedType annotationHolder) {
final boolean numberType =
isNumberType(annotationHolder.getType());
final boolean dateType = isDateType(annotationHolder.getType());
+ final boolean hasRawType = hasRawType(annotationHolder.getType());
final JsonbTypeDeserializer deserializer =
annotationHolder.getAnnotation(JsonbTypeDeserializer.class);
final JsonbTypeAdapter adapter =
annotationHolder.getAnnotation(JsonbTypeAdapter.class);
+ final JsonbTypeAdapter typeAdapter = hasRawType ?
getRawType(annotationHolder.getType()).getDeclaredAnnotation(JsonbTypeAdapter.class)
: null;
Review comment:
Shouldnt it be done in the decorated type? There shouldnt be much type
reflection there. Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
