rmannibucau commented on issue #55: JOHNZON-293 potential high memory 
consumption in dateconverter
URL: https://github.com/apache/johnzon/pull/55#issuecomment-562028365
 
 
   Hi @elexx , DateTimeFormatter and SimpleDateFormat patterns are not 1-1 so I 
guess this is a breaking change. It can also be good to configure the timezone 
if we are breaking the API - to ensure UTC by default.
   One option can be to import this 
https://github.com/apache/johnzon/blob/master/johnzon-jsonb/src/main/java/org/apache/johnzon/jsonb/JohnzonBuilder.java#L693
 natively in the mapper - and default converters - and drop it from jsonb 
module (except the built-in configuration/properties of jsonb but it is a few 
adapters).
   Finally for compatibility I guess we can try {datetimeformatter}catch(e) 
{new SimpleDateFormat()} to ensure we don't break version and dont need a 
version change for such internal.
   
   Hope it makes, sense, wdyt?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to