rmannibucau commented on a change in pull request #62: Added possibility to use
minus as array index for the remove operation.
URL: https://github.com/apache/johnzon/pull/62#discussion_r398512320
##########
File path:
johnzon-core/src/test/java/org/apache/johnzon/core/JsonPointerTest.java
##########
@@ -456,6 +456,19 @@ public void testRemoveArrayElement() {
assertEquals("[[\"bar\",\"baz\"]]", result.toString()); //
[["bar","baz"]]
}
+ @Test
+ public void testRemoveLastArrayElement() {
Review comment:
I was more thinking about the + case (know it is not what you changed but
your change moves from (a || b) to (a || (b && c)), I just want to prevent the
fact it becomes ((a || b) && c)
[or something else] during another enhancement by a test executed in the
build.
Hope it makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
