[ 
https://issues.apache.org/jira/browse/JOHNZON-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161474#comment-17161474
 ] 

Romain Manni-Bucau commented on JOHNZON-319:
--------------------------------------------

Hi Markus,

 

For existing properties yes,else I wouldnt modify mapperbuilder but the 
properties passed to the jsonp factories in the jsonb builder impl (no need to 
create a new api there since jsonp one already handles it and it is the way to 
enable it already today IMHO).

 

So rephrased, for me, it is mainly wiring some shortcut properties but not 
change the stack.

 

Hope it makes sense.

> Properties regarding Json reader/generator ignored if no JsonProvider is set
> ----------------------------------------------------------------------------
>
>                 Key: JOHNZON-319
>                 URL: https://issues.apache.org/jira/browse/JOHNZON-319
>             Project: Johnzon
>          Issue Type: Bug
>          Components: JSON-B
>    Affects Versions: 1.2.8
>            Reporter: Markus Jung
>            Priority: Minor
>         Attachments: ignored-property.zip
>
>
> JohnzonBuilder ignores properties which shouid affect the Json 
> reader/generator if no JsonProvider has been set. I noticed this using the 
> "org.apache.johnzon.max-string-length" property.
> JohnzonBuilder#build() looks somewhat like this behaviour is intended, but a 
> property just being ignored feels unintuitive. I'd be sending you a PR for 
> this, but I dont know this project well enough to decide whether or not 
> always initializing the generator/reader factories to ensure set properties 
> are being respected is a good idea. Maybe somebody could hint me in the right 
> direction there?
> I attached an example project that demonstrates this issue, the first call to 
> Jsonb#fromJson(String, Class) should already be throwing a 
> JsonParsingException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to