markuung commented on a change in pull request #67:
URL: https://github.com/apache/johnzon/pull/67#discussion_r460554609
##########
File path:
johnzon-jsonb/src/main/java/org/apache/johnzon/jsonb/JohnzonBuilder.java
##########
@@ -131,9 +131,12 @@ public Jsonb build() {
return it;
}).orElse(false);
- if
(config.getProperty(JsonbConfig.FORMATTING).map(Boolean.class::cast).orElse(false))
{
- builder.setPretty(true);
- }
+
config.getProperty(JsonbConfig.FORMATTING).map(Boolean.class::cast).ifPresent(builder::setPretty);
+
config.getProperty(AbstractJsonFactory.BUFFER_STRATEGY).map(String::valueOf).ifPresent(builder::setBufferStrategy);
Review comment:
JohnzonBuilder#generatorConfig() and JohnzonBuilder#readerConfig() also
use org.apache.johnzon.* like properties, also exposing json-p impl specific
properties, so I reused those. Should those maybe be changed too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
