rmannibucau commented on pull request #82: URL: https://github.com/apache/johnzon/pull/82#issuecomment-1070537422
> To only work with 2 Annotations (https://github.com/Serviceprovider, @ServiceConsumer) and get everything else for free. This is where the issue starts, you mix two string config locations: code and pom so IMHO it is saner to stick to pom only. Other point is that most dev will just drop these useless (for them) annotations until there is an IT which fails and they will not be able to solve it, so keeping it outside code is generally saner from my past experience (but I understand your OSGi first idea which works well for pure OSGi projects). > This isn't something, someone should care by hand. ( also not in the felix-plugin). Have to admit it is 1-1 with the annotation as of today for me except if you want the full OSGi vision you need to review code+pom (or build) whereas currently we have it in the pom in a single config so think it is maybe just a habit point? > And at the long term. I think that the bnd-maven-plugin replaces felix-plugin. I don't think so, most of the Karaf ecosystem relies on felix plugin and will likely continue AFAIK since it encapsulates a lot of things, enables to use bnd advanced features but also simplifies several things on top of it. maybe @jbonofre can confirm this point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
