[
https://issues.apache.org/jira/browse/JOHNZON-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616562#comment-17616562
]
Romain Manni-Bucau commented on JOHNZON-305:
--------------------------------------------
[~singingbush]
> packages that use automodules should not be published to maven central
Actually they can and there is no issue there until you want to use JPMS. The
message you get (from maven I assume?) is a bug in the maven plugin we can fix
if needed.
> Seeing as humanity exists on a timeline that continues to move forward can
> we please focus on supporting Java features today and for the future rather
> than a JDK that was released 8 years ago
I assume you mean JPMS is the future? We had this discussion and JPMS adoption
is pretty much dead for multiple reasons (it does not work in any EE server, it
does not work properly in graalvm even if last releases tried to enhance it, it
does not work with all but one packaging type - ex: fatjars are broken, it does
not solve any real life issue you cant solve between without, it does not bring
any perf improvement, it does not help much with modularity and for cases you
want modularity you miss version support , ecosystem is far to be mature with
it - most libs don't work properly there including big ones, ....). Note that
graalvm killed JPMS before it got adopted too and we support this more relevant
target.
So even if I'm not against adding a module-info.class (while it is generated
and not written manually) or just a Automatic-Module-Name in the
build/manifest.mf, please consider there is an ecosystem out there for the
project and people and even if you probably only build JPMS apps as of today,
it is not the case yet in the industry - central stats prooves it quite badly.
That said, do you want to do the PR to add Automatic-Module-Name in the
manifest and drop this warning?
> Johnzon should provide Java 9 module information
> ------------------------------------------------
>
> Key: JOHNZON-305
> URL: https://issues.apache.org/jira/browse/JOHNZON-305
> Project: Johnzon
> Issue Type: Improvement
> Components: Core, JAX-RS, JSON-B, Mapper, OSGi, Websocket
> Affects Versions: 1.2.3
> Reporter: Adrian Price
> Priority: Major
>
> Johnzon does not declare any Java 9 modules and consequently it is not usable
> with a modular Java 9+ program*. There are two possible approaches:
> # Add module-info.java files to each of johnzon-core, johnzon-jaxrs,
> johnzon-jsonb, johnzon-json-extras, johnzon-jsonschema, johnzon-mapper,
> johnzon-osgi, johnzon-websocket and possibly johnzon-maven-plugin.
> (Preferred, the 'correct way'.)
> # Configure maven-jar-plugin with an
> archive/manifestEntries/Automatic-Module-Name element. Probably best achieved
> with a plugin element in the parent /johnzon/pom.xml referencing a property
> to be defined in each sub-module (say ${johnzon.module.name}). (Quick 'n
> dirty?)
> I'm not sure, but it might even be appropriate to do both... needs research.
> *You get exceptions like this: 'Unable to make field private final
> javafx.beans.property.BooleanProperty
> io.github.demonfiddler.timer.model.MultiTimerBean.delayStart accessible:
> module io.github.demonfiddler.multitimer does not "opens
> io.github.demonfiddler.timer.model" to unnamed module @22036d57'. Also
> Eclipse problem markers like this: "Name of automatic module 'johnzon.core'
> is unstable, it is derived from the module's file name."
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
