rmannibucau commented on code in PR #94:
URL: https://github.com/apache/johnzon/pull/94#discussion_r994885019
##########
.github/dependabot.yml:
##########
@@ -0,0 +1,7 @@
+version: 2
Review Comment:
I'm really for not using depandabot which got proven to create more noise
than solving any actual issue in practise on most asf project, is it ok to drop
it?
##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,34 @@
+name: Maven
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ name: Test with Java ${{ matrix.jdk }}
+ #runs-on: ${{ matrix.os }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ jdk: [ '11', '17', '19' ]
+ dist: [ 'zulu' ]
+ include:
+ - { jdk: '8', dist: 'adopt' } # Zulu doesn't have JDK 8
+
+ steps:
+ - uses: actions/checkout@v3
+ - name: Set up JDK ${{ matrix.jdk }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ matrix.jdk }}
+ distribution: ${{ matrix.dist }}
+ cache: 'maven'
+
+ - name: Maven Rat Check
+ run: mvn -V apache-rat:check --no-transfer-progress
+
+ - name: Maven Verify
+ run: mvn -V verify --no-transfer-progress
Review Comment:
maybe add `MAVEN_OPTS=-Dmaven.artifact.threads=64`
##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,34 @@
+name: Maven
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ name: Test with Java ${{ matrix.jdk }}
+ #runs-on: ${{ matrix.os }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ jdk: [ '11', '17', '19' ]
+ dist: [ 'zulu' ]
+ include:
+ - { jdk: '8', dist: 'adopt' } # Zulu doesn't have JDK 8
Review Comment:
zulu stil has v8 -> https://cdn.azul.com/zulu/bin/
is it a big of the related action?
##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,34 @@
+name: Maven
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ name: Test with Java ${{ matrix.jdk }}
+ #runs-on: ${{ matrix.os }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ jdk: [ '11', '17', '19' ]
+ dist: [ 'zulu' ]
+ include:
+ - { jdk: '8', dist: 'adopt' } # Zulu doesn't have JDK 8
+
+ steps:
+ - uses: actions/checkout@v3
+ - name: Set up JDK ${{ matrix.jdk }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ matrix.jdk }}
+ distribution: ${{ matrix.dist }}
+ cache: 'maven'
+
+ - name: Maven Rat Check
+ run: mvn -V apache-rat:check --no-transfer-progress
+
+ - name: Maven Verify
+ run: mvn -V verify --no-transfer-progress
Review Comment:
`mvn package` is sufficient, verify just slows down the build with no gain
##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,34 @@
+name: Maven
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ name: Test with Java ${{ matrix.jdk }}
+ #runs-on: ${{ matrix.os }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ jdk: [ '11', '17', '19' ]
+ dist: [ 'zulu' ]
+ include:
+ - { jdk: '8', dist: 'adopt' } # Zulu doesn't have JDK 8
+
+ steps:
+ - uses: actions/checkout@v3
+ - name: Set up JDK ${{ matrix.jdk }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ matrix.jdk }}
+ distribution: ${{ matrix.dist }}
+ cache: 'maven'
+
+ - name: Maven Rat Check
+ run: mvn -V apache-rat:check --no-transfer-progress
Review Comment:
not needed thanks to next step
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
