rmannibucau commented on code in PR #99: URL: https://github.com/apache/johnzon/pull/99#discussion_r1087663108
########## johnzon-jsonb/pom.xml: ########## @@ -144,6 +144,7 @@ <artifactId>maven-bundle-plugin</artifactId> <configuration> <instructions> + <Automatic-Module-Name>johnzon.jsonb</Automatic-Module-Name> Review Comment: Well module-info or automatic name but all modules should have the same option (it is the key). module-info has some pitfalls and will break some integration - why we dont have it yet - but since we move to 2.0 very soon I guess door can be opened now if preferred but clearly a single solution for the full project :pray: . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org