rmannibucau commented on code in PR #100:
URL: https://github.com/apache/johnzon/pull/100#discussion_r1170384654


##########
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MapperConfig.java:
##########
@@ -98,6 +98,8 @@ public Object fromJson(JsonValue jsonObject, Type targetType, 
MappingParser pars
 
     private final SnippetFactory snippet;
 
+    private final Function<MapperConfig, Mappings> mappingsFactory;
+
     //CHECKSTYLE:OFF
     @Deprecated
     public MapperConfig(final LazyConverterMap adapters,

Review Comment:
   For the scope I have in mind it would be ok but it can be a limited scope 
(understand I will not fight if you modify the other but I have no real idea it 
can break other people).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to