jungm commented on code in PR #103:
URL: https://github.com/apache/johnzon/pull/103#discussion_r1180351187
##########
johnzon-jsonb/src/main/java/org/apache/johnzon/jsonb/JohnzonBuilder.java:
##########
@@ -234,6 +236,10 @@ public Jsonb build() {
Integer.parseInt(it.toString()))
.ifPresent(builder::setSnippetMaxLength);
+ // drop johnzon-mapper BigInteger/BigDecimal built in adapters to not
serialize those types as JsonString. See JSON-B spec 3.4.1
Review Comment:
1. reverted all changes I made in LazyConverterMap and simply added two
booleans to enable/disable BigDecimal/Integer string adapters
2. Now defaults to string, though I do have mixed feelings about this one.
Defaulting to string absolutely makes sense, but we're actively ignoring json-b
spec here now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
