Hey Romain,
no strong opinion on my side either ;)
Will fix the bin.xml and add the JSON-B API as well.
Thanks
Markus
On 17.06.24 20:45, Romain Manni-Bucau wrote:
Hi Markus,
Yes the bin.xml configuration is not complete it seems.
I don't have a strong opinion on wether it should be there or not while it
stays consistent accross all AsfEE projects (last time I checked tomee,
batchee, openwebbeans, meecrowave were adding API jar - idea being to
download and run without downloading yet another thing).
Best,
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le lun. 17 juin 2024 à 20:27, Markus Jung <ju...@apache.org> a écrit :
Hey all,
just noticed the following include in our binary assembly descriptor:
<include>jakar:geronimo-json-*</include> [1]
Ignoring the pretty obvious renaming error, was it ever intended for us to
ship the JakartaEE/JavaEE APIs with the binary package? This has actually
been misconfigured since the very first commit that introduced the
distribution module [2] as org.apache.johnzon:johnzon-* never matched the
API dependencies (should've been org.apache.johnzon:johnzon_*). The JSON-B
API also isn't mentioned at all, neither as a dependency nor in the bin.xml
file.
IMO we should just drop it since it never actually worked and as far as
I'm aware there has never been feedback by a user that has been missing
these JARs. Or do we actually have a need to ship these API jars?
Thanks
Marks
[1]
https://github.com/apache/johnzon/blob/d5665b9180b580f0594a269ce14fcec07d7d4ffa/johnzon-distribution/src/assembly/bin.xml#L34
[2]
https://github.com/apache/johnzon/commit/3eecf6b63510d11997c35d0e57d1c7bfa51320e9
