Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/805b643187e07c1d4dcd5047c3ac2dfa0a84e256#commitcomment-17176979
I agree, this is kind of a big deal. Thanks for catching this! I have used
this code before, but did not see clear improvements with class-based lms. Now
I know why :)
Regarding StateMinimizingLanguageModels: that would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
