GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/12
JOSHUA-252 Make it possible to use Maven to build Joshua
Hi Folks,
This PR is a beast. I think a Google Hangout would be best to talk through
what is going on.
Basically it,
* Mavenizes the entire codebase e.g. sets out the
src/main/java/org/apache/joshua/... structure.
* goes a long way to implementing the correct structure and notation for
Unit testing e.g. src/test/java/org/apache/joshua/...
* moves everything from $JOSHUA_HOM/tst to the correct src/test/java/...
directories then removes tst
* moves all test .java files from $JOSHUA_HOME/test to src/test/java/...
* removes the previous Eclipse project definitions which were committed to
the repos
* removes the thrax submodule. We should just pull this in as a dependency
from now on. I've therefore put up a PR for this over on
https://github.com/joshua-decoder/thrax/issues/11
...
As I expected there are a bunch of files which include Objects which ni
longer exist. If you pull this PR in to a branch and execute mvn clean install
you will see that this is the case with around 6 or 7 test files. We need to
collectively decide what to do with the missing imports.
Apart from that, work still t be done here is as follows
* ensure that all testing resources are moved into
$JOSHUA_HOME/src/test/resources. This folder is not currently created.
* Remove build.xml
* plan on how we are going to compile and package GIZA++, KenLM, etc. This
is something @KellenSunderland @buggtd and I discussed at the ApacheCon meetup
however there is still work to be done here.
The first thing i think, is to get the test classes compiling. Once we have
done that we can move on to getting the tests passing and stabilizing the Java
build code.
After that we can move on to the C++ build challenges.
All in all, a VERY successful week for Joshua. Looking forward to
stabilizing the Maven build as it will make things so much easier or us all
moving forward.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-252
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/12.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12
----
commit 8cdbc4b8e415fa1f45dd663e2a65bf69d7ef416d
Author: Lewis John McGibbney <[email protected]>
Date: 2016-05-14T03:49:55Z
JOSHUA-252 Make it possible to use Maven to build Joshua
commit 89e227585923e6c277a544579abc5a2b1fa91bef
Author: Lewis John McGibbney <[email protected]>
Date: 2016-05-14T07:53:34Z
JOSHUA-252 Make it possible to use Maven to build Joshua
commit f401535f5b50487c5c6e1f17c954904e32e5d2fb
Author: Lewis John McGibbney <[email protected]>
Date: 2016-05-14T08:44:43Z
JOSHUA-252 Make it possible to use Maven to build Joshua
commit 7f824b4eceefc96813f38cb6bf8c4e5f404f5f44
Author: Lewis John McGibbney <[email protected]>
Date: 2016-05-14T20:53:40Z
JOSHUA-252 Make it possible to use Maven to build Joshua
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
