Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131682
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/bloomfilter_lm/BloomFilterLanguageModel.java
---
@@ -62,7 +63,7 @@
/**
* The logger for this class.
*/
- public static final Logger logger =
Logger.getLogger(BloomFilterLanguageModel.class.getName());
+ public static final Logger LOG =
LoggerFactory.getLogger(BloomFilterLanguageModel.class);
--- End diff --
I think we should remove the System.err.println in this class and replace
with Log.error for consistency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
