Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/19aadf0e240acb09c5b4336068e6368083f26bef#commitcomment-17620734
In src/joshua/decoder/Decoder.java:
In src/joshua/decoder/Decoder.java on line 515:
what if one uses Decoder.decode() and not decodeAll()?
Is there a way to put this into the TranslationFactory by passing it a
reference to the feature functions? If someone calls
TranslationFactory().translation() it could execute this KenLM hack since at
this point one knows that the KenLM states can be destroyed.
Also, if TranslationFactory is used in this pattern I would suggest calling
it TranslationBuilder and adopt the builder pattern:
TranslationBuilder tb = new TranslationBuilder()
Translation translation =
tb.withAlignments().withFeatures().buildTranslation();
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
