[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303935#comment-15303935
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---------------------------------------

Github user mjpost commented on the pull request:

    https://github.com/apache/incubator-joshua/pull/12#issuecomment-222120221
  
    I went into joshua/decoder/chart_parser/ComputeNodeResult; adding and 
removing the following lines makes a huge difference in speed. So it looks like 
logging is neither (a) time-safe nor (b) thread-safe.
    
    Or that something is wrong. I can't get the decoder to output any 
statements using the logging properties. It's sort of a pain to have to rebuild 
a tarball every time you want to test something...
    
    FYI, I won't have any more time to spend on this before Tuesday.
    
    ```
    if (LOG.isDebugEnabled()) {
      LOG.debug("ComputeNodeResult():");
      LOG.debug("-> RULE {}", rule);
    }
    
    [snip]
    
    if (LOG.isDebugEnabled()) {
      LOG.debug("-> item.bestedge: {}", item);
      LOG.debug("-> TAIL NODE {}", item);
    }
    ```


> Make it possible to use Maven to build Joshua
> ---------------------------------------------
>
>                 Key: JOSHUA-252
>                 URL: https://issues.apache.org/jira/browse/JOSHUA-252
>             Project: Joshua
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tommaso Teofili
>            Assignee: Tommaso Teofili
>             Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to