[ 
https://issues.apache.org/jira/browse/JOSHUA-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307596#comment-15307596
 ] 

Kellen Sunderland commented on JOSHUA-274:
------------------------------------------

I would propose we don't put anything web server specific in the core Joshua 
jar.  In my mind the Joshua package should really contain just a translation 
library.  We could provide other jars with CLIs and a Restful service consuming 
this library (maybe even built by default).  

My reasoning is that if you are consuming Joshua strictly as a translation 
library you may prefer there be no web-service code there.  If you're already 
hosting this code in your own web service it could be quite confusing to have 
similar functionality in the library you are exposing.  Worse would be the case 
where through a configuration error you accidentally turn on a second web 
service (maybe on a different port).  

The other point I'd make is that by including http functionality in the main 
package we're adding a bunch of dependancies on things like json libs, etc.  
These dependancies could conflict with anyone wanting to use the package as a 
service. 

> Use another HTTPServer other than Suns
> --------------------------------------
>
>                 Key: JOSHUA-274
>                 URL: https://issues.apache.org/jira/browse/JOSHUA-274
>             Project: Joshua
>          Issue Type: Improvement
>          Components: decoders
>    Affects Versions: 6.0.5
>            Reporter: Lewis John McGibbney
>            Priority: Critical
>             Fix For: 6.1
>
>
> This issue concerns the use of the 
> [HttpServer|https://github.com/apache/incubator-joshua/blob/master/src/joshua/decoder/JoshuaDecoder.java#L31]
>  within JoshuaDecoder.java. 
> We should replace the com.sun.net.httpserver.HttpServer implementation and 
> other Sun classes with ones from the Java API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to