Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/20
So it seems this isn't compatible with JOSHUA-273 (which is fine), but
provides some of its functionality.
One concern I have is the complexity of juggling the master branch,
JOSHUA-252, JOSHUA-273, and these changes in my head right now. I'd really like
to get JOSHUA-252 merged in to help simplify things.
We would then want to merge either (a) JOSHUA-273, after having
Decoder.decodeAll() return Translations, (b) merge this PR, or both. The reason
I'm pushing a bit for JOSHUA-273 is because I also removed a lot of the
redundancies in k-best extraction and so on, collapsed Translation and
StructuredTranslation, and did some other things. It seems that it subsumes
this PR? In which case, it might be less complex to go that route. But correct
me if I'm wrong, or if JOSHUA-273 is headed in the wrong direction, or if this
PR has some short-term advantage that can help us out in the meantime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
