[GitHub] incubator-joshua pull request #:

[fhieber]

Github user fhieber commented on the pull request:

    
https://github.com/apache/incubator-joshua/commit/6d2213a20b74432fc7cb131c732f7507b74053e9#commitcomment-17933645
  
    In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java:
    In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java on 
line 57:
    Hi Matt,
     
    Thanks, StructuredTranslation is an object to be used in a downstream 
codebase and I think it would be good to have minimal dependencies on Joshua 
objects as possible there :)
     
    Regarding your question:
    I’d go for a container/value object for the reason stated above if 
possible.
     
    Cheers,
    Felix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---