Github user logogin commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
Hi @mjpost . I wanted general opinion on the proposal but looks mostly
people support it. Some things to take into account if that will go into master:
* joshua-servet contains only basic functionality and does not represent a
drop-in replacement for the
[ServerThread](https://github.com/apache/incubator-joshua/blob/55e88d1fce0e2654d090c14d999e43acd6ac8820/src/main/java/org/apache/joshua/server/ServerThread.java)
as of now. The idea was to get something working, collect opinions and extend
if necessary.
* The configuration of the Decider supported only via `decoderArgsLine`
init parameter. There are many ways to extend that (i.e. via system property).
But I am just unsure which way is preferable.
* Translation with request body payload now requires POST method instead of
GET. Although that is more natural for the RESTful application, it might cause
some incompatibilities with existing tools.
* The artifacts for the corresponding modules are
`joshua-core-<version>.jar` and `joshua-servlet-<version>.jar` respectively.
This might require updating some bash scripts or tools with hard-coded artifact
names. If that is the case, please list those here and I will look for the
solutions.
* Since folder layout also changed, above might be applicable here as well.
* Probably the most important - after that change, there will be no more
updates to `joshua-<veriosn>.jar` in the maven repository. We will have to
follow this naming convention and support new artifact naming. So that is
pretty crucial point and if we have better naming or modules hierarchy, we need
to settle it before merging with master.
But if you are ok with all those point we can definitely proceed and merge.
Thank to the git time machine we can travel to the past :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
