GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/45
Refactored the threading code in the JoshuaDecoder class.
These commits do some refactoring and reworking of the threading code in
JoshuaDecoder. The principal motivation for this refactor is to reduce our use
on custom code, and utilize libraries. It should also improve readability and
reduce the potential for bugs as we've removed a large chunk of fairly complex
code.
Note: I've seen some errors with tests due to static Vocab issues with my
new test. Will look into fixing this (and will fix right away if required for
this PR).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KellenSunderland/incubator-joshua master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/45.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #45
----
commit d1c9c074544d72ee5335bdd83fe415b45098ab08
Author: Kellen Sunderland <[email protected]>
Date: 2016-08-29T08:08:10Z
JOSHUA-285 JOSHUA-296 Refactored threading in order to properly propagate
failures and remove custom code
commit 0bb293295e3670c7449815941566578facd247e9
Author: Kellen Sunderland <[email protected]>
Date: 2016-08-29T11:53:53Z
Renamed DecoderThread to DecoderTask
commit 6d8f684836ddc25e40bb32f91d24d3f6e5eb745b
Author: Kellen Sunderland <[email protected]>
Date: 2016-08-29T11:58:52Z
Renamed Translations class to TranslationResponseStream
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
