GitHub user maxthomas opened a pull request:
https://github.com/apache/incubator-joshua/pull/49
7 with master
Merges in master (1 commit, 840eb4c) into 7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maxthomas/incubator-joshua 7-with-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit 840eb4ce4854d3f5e4f792ce4d909d6276bfcb08
Author: max thomas <[email protected]>
Date: 2016-08-18T19:04:52Z
Fix a number of issues:
- Reader now implements autocloseable
- Close various leaks from LineReader
- LineReader no longer implements custom finalize(). Resources should be
explicitly closed when no longer needed. The compiler helps with this.
- Start refactoring copy/pasted code into a new type:
ExistingUTF8EncodedTextFile.
There is so much use of text files that this should really have
its own type.
- Fix warnings about unused fields, unused methods
- Delete some old/legacy/unused classes
commit b0b70627225838a34508b8199c8b2156c1774ca4
Author: max thomas <[email protected]>
Date: 2016-08-30T20:24:24Z
Merge branch 'master' into 7-with-master
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
