[
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510179#comment-15510179
]
ASF GitHub Bot commented on JOSHUA-299:
---------------------------------------
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/67
JOSHUA-299 Move regression tests to proper unit tests
Hi folks, this is one stage closer to us addressing
https://issues.apache.org/jira/browse/JOSHUA-299
Of note here, I manually constructed the decoder output from essentially
concatenating various output from a StructuredTranslation. What should be noted
here is that we actually seem to loose some accuracy.... note the old file
provided decoder output of ```0 ||| help ||| tm_glue_0=1.000 ||| 0.000```
whereas now we provide ```0 ||| help ||| tm_glue_0=1.0 ||| 0.0```
Any comments?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-299
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit 5dd80a37217f4f61ca00aedd256947a412e13771
Author: Lewis John McGibbney <[email protected]>
Date: 2016-09-21T14:53:21Z
JOSHUA-299 Move regression tests to proper unit tests
----
> Move regression tests to proper unit tests
> ------------------------------------------
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
> Issue Type: Bug
> Reporter: Matt Post
> Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been
> moved to proper unit tests, but this move should be completed, and the
> regression tests should be deleted. This should be done for 6.1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
