Same here, thanks, Tom.
> On Nov 27, 2016, at 3:38 AM, kellen sunderland <[email protected]> > wrote: > > Definitely guilty of this. I'll check the release checklist in the > future. Thanks for the reminder Tom. > > On Nov 26, 2016 1:27 PM, "Tom Barber" <[email protected]> wrote: > > Hello folks, > > I see plenty of +1's going through the release vote, which is great to see > people taking an active role in getting the release shipped. > > For those of you who are new to the ASF there are a bunch of requirements > to sign off for a release which you can find here: > > http://incubator.apache.org/guides/releasemanagement.html#check-list > > My current concern is that people who are new to the incubator are +1'ing > software for release without check all or part of the release cycle. Whilst > not mandatory, when you +1 a release please can you try to indicate what > you've checked. The reason for this is, the tag Lewis has built off isn't > the tip of master, so if you're basing your +1 on your day to day > development and knowledge of the code base, that's not always whats > shipped. Also in the branching process, its possible merges or alterations > were accidentally made that Lewis has missed (this is very unlikely I know > but you know, code changes). Also people build software on different OS's, > versions of OS's etc so just because it builds on Lewis's laptop doesn't > mean it builds on mine, for example. > > Also regarding licenses, disclaimers etc, people notice different things or > interpret stuff differently. its always possible that someone might miss a > library etc so its important multiple eyes run over the same stuff. > > Cheers, > > Tom > > -- > Tom Barber > CTO Spicule LTD > [email protected] > > http://spicule.co.uk > > GB: +44(0)5603641316 > US: +18448141689
