[
https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15708118#comment-15708118
]
Kellen Sunderland edited comment on JOSHUA-324 at 11/30/16 10:15 AM:
---------------------------------------------------------------------
Opening a pull shortly to add a license to [7]. Sorry for missing this one.
The binary file highlighted in [11] is used in the regression test
org.apache.joshua.decoder.ff.lm.berkeley_lm.LMGrammarBerkeleyTest. I think
it's valuable to include it as part of the test suite. I don't think it
includes any executable code or compiled source if that's a concern. It's just
a serialized POJO. We can remove this test if needed for the release, but I'm
going to read up on the binary policy to see if there's some way we can leave
it in.
was (Author: kellen.sunderland):
Opening a pull shortly to add a license to [7]. Sorry for missing this one.
The binary file highlighted in [11] is used in the regression test
org.apache.joshua.decoder.ff.lm.berkeley_lm.LMGrammarBerkeleyTest. I think
it's valuable to include it as part of the test suite. I don't think it
includes any executable code if that's a concern. It's just a serialized POJO.
We can remove this test if needed for the release, but I'm going to read up on
the binary policy to see if there's some way we can leave it in.
> Address Apache Joshua 6.1 RC#2 Issues
> -------------------------------------
>
> Key: JOSHUA-324
> URL: https://issues.apache.org/jira/browse/JOSHUA-324
> Project: Joshua
> Issue Type: Task
> Affects Versions: 6.1
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Blocker
> Fix For: 6.1
>
>
> Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows
> {code}
> ==========================
> - Your missing incubating in the release artifacts name. [1]
> - There are a number of binary files in the source release that look to be
> compiled source code.
> I checked:
> - name doesn’t include incubating
> - signatures and hashes correct
> - DISCLAIMER exists
> - LICENSE is missing a few things (see below)
> - a source file is missing an Apache header [7]
> - Several unexpected binary files are contained in the source release
> [8][9][10][11]
> - Can compile from source
> License is missing:
> - MIT licensed normalize.css v3.0.3 bundled in [5]
> - glyph icon fonts [6]
> Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually
> both are bare or both have .txt extension.
> Also while looking at your site I noticed that the download links of you
> incubating site [2] points to github, please change to point to the offical
> release area.
> Also the 6.1 release has already been tagged and it available for public
> download on github [4] before this vote is finished. This is IMO against
> Apache release policy [3] please remove.
> I also notice you recently released the language packs (18th Nov) but there
> doesn’t seem to have been a vote for that? Any reason for this?
> ===========================
> [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
> [2]
> https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home
> [3] http://www.apache.org/dev/release.html#what
> [4] https://github.com/apache/incubator-joshua/releases
> [5] ./demo/bootstrap/css/bootstrap.min.css
> [6] apache-joshua-6.1/demo/bootstrap/fonts/*
> [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java
> [8] ./bin/GIZA++
> [9] ./bin/mkcls
> [10 ]./bin/snt2cooc.out
> [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz
> [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html
> [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html
> {code}
> This is a blocking issue and until addressed we cannot release 6.1-incubating
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
