Multiple File.open failures with rubinius file/open_spec.rb tests
-----------------------------------------------------------------
Key: JRUBY-1623
URL: http://jira.codehaus.org/browse/JRUBY-1623
Project: JRuby
Issue Type: Bug
Components: Core Classes/Modules
Affects Versions: JRuby 1.x
Environment: Using the latest jruby built from trunk, rev. 5061
Reporter: Vladimir Sizikov
Attachments: file_open_more_failures-2.diff
Execution of the latest rubinius specs:
bin/mspec -f s -t jruby spec/core/file/open_spec.rb
produces (among others), the following errors:
- open a file that no exists when use File::WRONLY mode (ERROR - 3)
- raise an IO exception when read in a block opened with
File::RDONLY|File::APPEND mode (ERROR - 4)
- can read in a block when call open with File::EXCL mode (ERROR - 5)
- raise an Errorno::EEXIST if the file exists when open with
File::CREAT|File::EXCL (ERROR - 6)
- raise an Errorno::EEXIST if the file exists when open with
File::RDONLY|File::APPEND (ERROR - 7)
- create a new file when use File::TRUNC mode (ERROR - 8)
- can't read in a block when call open with File::TRUNC mode (ERROR - 9)
- expected errors (ERROR - 10)
The proposed patch fixes all of them and doesn't introduce any new errors.
In fact, this patch also fixes 5 test cases in other File specs in Rubinius as
well.
Before the patch: 57 file spec failures.
After the patch: 44 file spec failures (and no new ones)
All JRuby tests pass too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
