File.fnmatch works incorrectly with case sensitivity
----------------------------------------------------
Key: JRUBY-1625
URL: http://jira.codehaus.org/browse/JRUBY-1625
Project: JRuby
Issue Type: Bug
Components: Core Classes/Modules
Affects Versions: JRuby 1.x
Environment: Ubuntu Linux 7.10,
JRuby 1.1b1
Reporter: Vladimir Sizikov
Attachments: file_fnmatch.rb
File.fnmatch('cat', 'CAT') returns true in JRuby, and false in MRI.
Also, File::FNM_CASEFOLD flag doesn't have any effect on results.
This leads to 2 Rubinius spec test failures:
1)
File.fnmatch matches characters with a case sensitive comparison FAILED
Expected true to equal false:
/opt/work/rubinius/spec/mini_rspec.rb:217:in `=='
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:40:in `=='
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:39:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:355:in `it'
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:39:in `it'
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:39:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:399:in `describe'
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:2:in `describe'
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:2:in `call'
/opt/work/rubinius/./spec/core/file/../../spec_helper.rb:152:in
`it_behaves_like'
/opt/work/rubinius/./spec/core/file/fnmatch_spec.rb:5:in `it_behaves_like'
/opt/work/rubinius/./spec/core/file/fnmatch_spec.rb:4:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:399:in `describe'
/opt/work/rubinius/./spec/core/file/fnmatch_spec.rb:4:in `describe'
/opt/work/rubinius/./spec/core/file/fnmatch_spec.rb:4:in `load'
last_mspec.rb:11:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:6:in `each'
2)
File.fnmatch? matches characters with a case sensitive comparison FAILED
Expected true to equal false:
/opt/work/rubinius/spec/mini_rspec.rb:217:in `=='
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:40:in `=='
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:39:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:403:in `it'
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:39:in `it'
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:39:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:399:in `describe'
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:2:in `describe'
/opt/work/rubinius/./spec/core/file/shared/fnmatch.rb:2:in `call'
/opt/work/rubinius/./spec/core/file/../../spec_helper.rb:152:in
`it_behaves_like'
/opt/work/rubinius/./spec/core/file/fnmatch_spec.rb:9:in `it_behaves_like'
/opt/work/rubinius/./spec/core/file/fnmatch_spec.rb:8:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:399:in `describe'
/opt/work/rubinius/./spec/core/file/fnmatch_spec.rb:8:in `describe'
/opt/work/rubinius/./spec/core/file/fnmatch_spec.rb:8:in `load'
last_mspec.rb:11:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:6:in `each'
The supplied patch fixes both test failures and adds the sensitivy flag back.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
