Numerous StringIO spec test failures
------------------------------------
Key: JRUBY-1684
URL: http://jira.codehaus.org/browse/JRUBY-1684
Project: JRuby
Issue Type: Bug
Components: Core Classes/Modules
Environment: JRuby 1.1b1, latest trunk
Reporter: Vladimir Sizikov
Attachments: stringio_fixes.diff
Running the latest rubinius specs against stringio reveals 10 test failures.
The proposed patch fixes 7 of them, leaving 3 failures for StringIO#reopen
unresolved, since it's hard to verify what is a correct behavior, MRI 1.8.6 has
a bug and doesn't support reopen method at all! :)
Once reopen is restored in Ruby, we can fix the rest of failures (in the
separate issue, I guess).
Here are the test failures that were fixed:
#>bin/mspec -t jruby spec/library/stringio_spec.rb
Started
................................................E........FF.................F.FFE................EE.
..........
Finished in 0.47100000000000003 seconds
1)
StringIO#pos= should raise EINVAL if given a negative argument FAILED
Expected Errno::EINVAL, nothing raised
/opt/work/rubinius/./spec/library/../mspec_helper.rb:27:in `should_raise'
/opt/work/rubinius/./spec/library/stringio_spec.rb:406:in `should_raise'
/opt/work/rubinius/./spec/library/stringio_spec.rb:406:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:414:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:405:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:405:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:395:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:395:in `load'
last_mspec.rb:12:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:7:in `each'
2)
StringIO#puts flattens a nested array before writing it FAILED
Expected "12345\n" to equal "1\n2\n3\n4\n5\n"
/opt/work/rubinius/spec/mini_rspec.rb:221:in `=='
/opt/work/rubinius/./spec/library/stringio_spec.rb:488:in `=='
/opt/work/rubinius/./spec/library/stringio_spec.rb:486:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:414:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:486:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:486:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:454:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:454:in `load'
last_mspec.rb:12:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:7:in `each'
3)
StringIO#puts writes [...] for a recursive array arg FAILED
Expected "22[...]\n" to equal "2\n[...]\n"
/opt/work/rubinius/spec/mini_rspec.rb:221:in `=='
/opt/work/rubinius/./spec/library/stringio_spec.rb:495:in `=='
/opt/work/rubinius/./spec/library/stringio_spec.rb:491:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:414:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:491:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:491:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:454:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:454:in `load'
last_mspec.rb:12:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:7:in `each'
7)
StringIO#reopen should deny access to prevent truncation of a frozen string
FAILED
Expected Errno::EACCES, nothing raised
/opt/work/rubinius/./spec/library/../mspec_helper.rb:27:in `should_raise'
/opt/work/rubinius/./spec/library/stringio_spec.rb:653:in `should_raise'
/opt/work/rubinius/./spec/library/stringio_spec.rb:653:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:414:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:651:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:651:in `compliant'
/opt/work/rubinius/./spec/library/../spec_helper.rb:76:in `compliant'
/opt/work/rubinius/./spec/library/stringio_spec.rb:651:in `failure'
/opt/work/rubinius/./spec/library/../spec_helper.rb:80:in `failure'
/opt/work/rubinius/./spec/library/stringio_spec.rb:651:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:616:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:616:in `load'
last_mspec.rb:12:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:7:in `each'
8)
StringIO#sysread should read to the end of the string if length is omitted
FAILED
wrong number of arguments (0 for 1)
/opt/work/rubinius/./spec/library/stringio_spec.rb:800
/opt/work/rubinius/./spec/library/stringio_spec.rb:800:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:414:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:800:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:800:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:791:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:791:in `load'
last_mspec.rb:12:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:7:in `each'
9)
StringIO#sysread should raise EOFError after the end of the string FAILED
wrong number of arguments (0 for 1)
/opt/work/rubinius/./spec/library/stringio_spec.rb:804
/opt/work/rubinius/./spec/library/stringio_spec.rb:804:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:414:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:804:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:804:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:791:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:791:in `load'
last_mspec.rb:12:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:7:in `each'
*********************************************************************************************
And here are the failures that remain:
1)
StringIO#reopen should reopen a stream when given a String argument FAILED
Expected "goodbyex" to equal "xoodbye"
/opt/work/rubinius/spec/mini_rspec.rb:221:in `=='
/opt/work/rubinius/./spec/library/stringio_spec.rb:626:in `=='
/opt/work/rubinius/./spec/library/stringio_spec.rb:622:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:414:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:622:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:622:in `failure'
/opt/work/rubinius/./spec/library/../spec_helper.rb:80:in `failure'
/opt/work/rubinius/./spec/library/stringio_spec.rb:622:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:616:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:616:in `load'
last_mspec.rb:12:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:7:in `each'
2)
StringIO#reopen should reopen and truncate when reopened in write mode FAILED
Expected "goodbye" to equal ""
/opt/work/rubinius/spec/mini_rspec.rb:221:in `=='
/opt/work/rubinius/./spec/library/stringio_spec.rb:638:in `=='
/opt/work/rubinius/./spec/library/stringio_spec.rb:636:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:414:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:636:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:636:in `failure'
/opt/work/rubinius/./spec/library/../spec_helper.rb:80:in `failure'
/opt/work/rubinius/./spec/library/stringio_spec.rb:636:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:616:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:616:in `load'
last_mspec.rb:12:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:7:in `each'
3)
StringIO#reopen should truncate the given string, not a copy FAILED
Expected "goodbye" to equal ""
/opt/work/rubinius/spec/mini_rspec.rb:221:in `=='
/opt/work/rubinius/./spec/library/stringio_spec.rb:646:in `=='
/opt/work/rubinius/./spec/library/stringio_spec.rb:643:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:414:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:643:in `it'
/opt/work/rubinius/./spec/library/stringio_spec.rb:643:in `failure'
/opt/work/rubinius/./spec/library/../spec_helper.rb:80:in `failure'
/opt/work/rubinius/./spec/library/stringio_spec.rb:643:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:616:in `describe'
/opt/work/rubinius/./spec/library/stringio_spec.rb:616:in `load'
last_mspec.rb:12:in `load'
last_mspec.rb:1:in `each'
last_mspec.rb:7:in `each'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
