String#capitalize! handles frozen empty string incompatibly
-----------------------------------------------------------

                 Key: JRUBY-1719
                 URL: http://jira.codehaus.org/browse/JRUBY-1719
             Project: JRuby
          Issue Type: Bug
          Components: Core Classes/Modules
    Affects Versions: JRuby 1.x
         Environment: JRuby 1.1b1, latest trunk
            Reporter: Vladimir Sizikov
         Attachments: string_capitalize.diff

"".freeze.capitalize!

returns nil in JRuby, but
returns: TypeError: can't modify frozen string, in MRI.

This causes one of the Rubinius spec failures:

1)
String#capitalize! raises a TypeError when self is frozen FAILED
Expected TypeError, nothing raised
/opt/work/rubinius/./spec/core/string/../../mspec_helper.rb:27:in `should_raise'
/opt/work/rubinius/./spec/core/string/capitalize_spec.rb:51:in `should_raise'
/opt/work/rubinius/./spec/core/string/capitalize_spec.rb:51:in `each'
/opt/work/rubinius/./spec/core/string/capitalize_spec.rb:49:in `each'
/opt/work/rubinius/./spec/core/string/capitalize_spec.rb:51:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:359:in `it'
/opt/work/rubinius/./spec/core/string/capitalize_spec.rb:48:in `it'
/opt/work/rubinius/./spec/core/string/capitalize_spec.rb:48:in `compliant'
/opt/work/rubinius/./spec/core/string/../../spec_helper.rb:76:in `compliant'
/opt/work/rubinius/./spec/core/string/capitalize_spec.rb:48:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/core/string/capitalize_spec.rb:31:in `describe'
/opt/work/rubinius/./spec/core/string/capitalize_spec.rb:31:in `load'
tmp/last_mspec.rb:13:in `load'
tmp/last_mspec.rb:1:in `each'
tmp/last_mspec.rb:7:in `each'

The proposed patch fixes the incompatibility, and the spec test failure.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to