String#rindex works incorrectly with FixNum parameters
------------------------------------------------------
Key: JRUBY-1732
URL: http://jira.codehaus.org/browse/JRUBY-1732
Project: JRuby
Issue Type: Bug
Components: Core Classes/Modules
Affects Versions: JRuby 1.x
Environment: Latest JRuby 1.1b1 from trunk
Reporter: Vladimir Sizikov
Attachments: string-rindex-with-fixnum-parameter-is-incorrect.patch,
string_rindex_fixnum.rb
Consider the following example:
{noformat}
puts "hello".rindex(256 * 3 + ?e)
puts "hello".rindex(-(256 - ?e))
{noformat}
MRI 1.8 and Rubinius print:
nil
nil
JRuby prits:
1
1
This also leads to the rubinius spec failure:
39)
String#rindex with Fixnum doesn't use fixnum % 256 FAILED
Expected 1 to equal nil
/opt/work/rubinius/spec/mini_rspec.rb:221:in `=='
/opt/work/rubinius/./spec/core/string/rindex_spec.rb:55:in `=='
/opt/work/rubinius/./spec/core/string/rindex_spec.rb:54:in `it'
/opt/work/rubinius/spec/mini_rspec.rb:414:in `it'
/opt/work/rubinius/./spec/core/string/rindex_spec.rb:54:in `it'
/opt/work/rubinius/./spec/core/string/rindex_spec.rb:54:in `describe'
/opt/work/rubinius/spec/mini_rspec.rb:410:in `describe'
/opt/work/rubinius/./spec/core/string/rindex_spec.rb:48:in `describe'
/opt/work/rubinius/./spec/core/string/rindex_spec.rb:48:in `load'
tmp/last_mspec.rb:13:in `load'
tmp/last_mspec.rb:1:in `each'
tmp/last_mspec.rb:7:in `each'
The proposed patch fixes the problem and the spec failure.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
