retroweaver tasks should use verify option
------------------------------------------

                 Key: JRUBY-1751
                 URL: http://jira.codehaus.org/browse/JRUBY-1751
             Project: JRuby
          Issue Type: Improvement
    Affects Versions: JRuby 1.x
            Reporter: Xavier Le Vourch
            Assignee: Thomas E Enebo
         Attachments: retroweaver_verify_patch.txt

I recently became aware that you're using retroweaver on the trunk to generate 
1.4 compatible jar files. I've looked at how it's done and the verifier option 
should be set to make sure all 1.5 features used in jruby are supported, which 
is not the case with the retroweaver 2.0 version you're using.

There are problems with BigDecimal and Character methods but I've already fixed 
that in retroweaver's svn repository and it will be available in the next 2.0.3 
version to be released shortly.

There's also a problem with the joni.jar file but it wasn't there with an older 
version of the jar file or if I compile joni.jar from svn so it looks like a 
packaging issue with joni.jar for revision 5298. When using the svn version of 
retroweaver and a locally compiled joni.jar, there are no verify errors so the 
weaved jar files should work fine with 1.4.

The attached patch needs to be modified as the location of the 1.4 rt.jar is 
hard coded now but that should be coming from a property definition.

The "failonerror" flag is set to false but once all problems are solved, it 
should probably be enabled to make sure compatibility issues are identified 
quickly.

Finally, the backport library needs to be in the path during the weaving as 
retroweaver will dynamically parse the jar to discover the supported methods.

Let me know if you need extra support for retroweaver,

Xavier

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to